On 1/15/24 04:07, Jan Beulich wrote: > On 12.01.2024 16:06, Roger Pau Monné wrote: >> On Tue, Jan 09, 2024 at 04:51:24PM -0500, Stewart Hildebrand wrote: >>> From: Oleksandr Andrushchenko <[email protected]> >>> + /* >>> + * Make sure that the guest set address has the same page offset >>> + * as the physical address on the host or otherwise things won't >>> work as >>> + * expected. >>> + */ >>> + if ( PAGE_OFFSET(bar->guest_addr) != PAGE_OFFSET(bar->addr) ) >>> + { >>> + gprintk(XENLOG_G_WARNING, >>> + "%pp: Can't map BAR%d because of page offset mismatch: >>> %lx vs %lx\n", >> ^u >> >> Also when using the x modifier it's better to also use # to print the >> 0x prefix. You can also reduce the length of the message using >> s/because of/due to/ IMO: >> >> %pp: Can't map BAR%u due to offset mismatch: %lx vs %lx > > Or even > > %pp: can't map BAR%u - offset mismatch: %lx vs %lx > > ?
Using # that becomes: "%pp: can't map BAR%u - offset mismatch: %#lx vs %#lx\n" I'll send v12.2. > Note also my use of lower-case 'c', which brings this log message in > line with all pre-existing (prior to the whole series) vPCI log messages > starting with "%pp: " (when not limiting to thus-prefixed there are a > couple of "Failed to ..." outliers). > > Jan
