Hi Jan, On 12/20/23 5:48 AM, Jan Beulich wrote: > On 15.12.2023 03:44, Shawn Anastasio wrote: >> Now that we have common code building, there's no need to keep the old >> itoa64+debug print function in mm-radix.c >> >> Signed-off-by: Shawn Anastasio <[email protected]> > > Looks okay, just one question: > >> --- a/xen/arch/ppc/mm-radix.c >> +++ b/xen/arch/ppc/mm-radix.c >> @@ -15,6 +15,12 @@ >> >> void enable_mmu(void); >> >> +#ifdef NDEBUG >> +#define radix_dprintk(...) >> +#else >> +#define radix_dprintk(msg, ...) printk(XENLOG_DEBUG msg, ## __VA_ARGS__) >> +#endif > > Do you really mean NDEBUG here, and not CONFIG_DEBUG? NDEBUG is generally > supposed to only control ASSERT() behavior. >
Thanks for pointing this out. CONFIG_DEBUG does indeed seem to be a better fit here. Will change in v3. > Jan Thanks, Shawn
