Hi Julien, On Tue, Jun 5, 2018 at 8:00 PM, Julien Grall <julien.gr...@arm.com> wrote:
> > > On 05/06/18 18:24, Julien Grall wrote: > >> Hi Mirela, >> >> On 01/06/18 14:17, Mirela Simonovic wrote: >> >>> Linux/dom0 accesses OSLSR register when saving CPU context during the >>> suspend procedure. Xen traps access to this register, but has no handling >>> for it. Consequently, Xen injects undef exception to linux, causing it to >>> crash. This patch adds handling of the trapped access to OSLSR as read >>> only as a fixed value. >>> >> >> Can you please mention that you introduced handle_ro_read_val() and >> rework handle_ro_raz()? >> >> >>> Signed-off-by: Mirela Simonovic <mirela.simono...@aggios.com> >>> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> >>> Acked-by: Julien Grall <julien.gr...@arm.com> >>> >> >> The reviewed-by/acked-by tags should only be kept when there are minor >> changes in the code (and the reviewer is happy with them). This is very >> important for the former as the tag means the reviewer read your code and >> confirm this is correct. >> >> As you change quite a bit the patch, those 2 tags should have been >> removed. >> >> Stefano, are you still happy with the Reviewed-by? >> > > Stefano mentioned on IRC he was happy with the reviewed-by kept. > > I will go ahead with merging the series. For this patch, I will add the > following in the commit message: > > "For convenience, introduce a new helper handle_ro_read_val() based on > handle_ro_raz() that will return a specified value on read and re-implement > handle_ro_raz() based on the new helper". > > Great, thanks! > Cheers, > > -- > Julien Grall >
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
