On Tue, 23 Jan 2024, Jan Beulich wrote: > On 22.01.2024 23:47, Stefano Stabellini wrote: > > On Mon, 22 Jan 2024, Jan Beulich wrote: > >> What definitely needs clarifying is what "review" is: Are R-b tags > >> counted, or is it the number of replies sent commenting on patches? > > > > Yes, I think this needs to be clarified. I would say Reviewed-by tags. > > Which may end up unfair. It's not uncommon for one person to do a lot > of review on a patch, and for someone else to then ack the final > version that goes in. In the end this is then no different from basing > the decision on simple numbers, without regard to actual (potentially > heavily differing) effort behind each individual instance.
I had thought about the case you describe too. This is why it is stated as "maintainers with >= 20 reviews in the last 2 releases". So it requires for the person to also be a maintainer. The bar to become a maintainer is already pretty high. Random individuals that subscribe to xen-devel and start replying Reviewed-by to every patch would be excluded. On the other hand, it would not account for reviews done by non-maintainers. However, non-maintainers are likely to be contributors so they would probably fall within the other category.
