On 26.01.2024 21:54, Andrew Cooper wrote: > --- a/xen/arch/x86/include/asm/bug.h > +++ b/xen/arch/x86/include/asm/bug.h > @@ -1,28 +1,8 @@ > #ifndef __X86_BUG_H__ > #define __X86_BUG_H__ > > -/* > - * Please do not include in the header any header that might > - * use BUG/ASSERT/etc maros asthey will be defined later after > - * the return to <xen/bug.h> from the current header: > - * > - * <xen/bug.h>: > - * ... > - * <asm/bug.h>: > - * ... > - * <any_header_which_uses_BUG/ASSERT/etc macros.h> > - * ... > - * ... > - * #define BUG() ... > - * ... > - * #define ASSERT() ... > - * ... > - */ > -
Leaving aside the clumsiness of the initial text, other than in common/bug.c I don't see why this comment is to go away (and, if at all, in this very patch). With it retained or the removal suitably explained Acked-by: Jan Beulich <[email protected]> Jan > #ifndef __ASSEMBLY__ > > -#define BUG_DEBUGGER_TRAP_FATAL(regs) debugger_trap_fatal(X86_EXC_GP,regs) > - > #define BUG_INSTR "ud2" > #define BUG_ASM_CONST "c" >
