Hi Andrew, On 1/30/24 4:28 PM, Andrew Cooper wrote: > All architectures have copy&pasted bad logic from x86. > > OFFSET() having a trailing semi-colon within the macro expansion can be a > problematic pattern. It's benign in this case, but fix it anyway. > > Perform style fixes for the other macros, and tame the mess of BLANK() > position to be consistent (one BLANK() after each block) so the intermediate > form is legible too. > > No functional change. > > Signed-off-by: Andrew Cooper <[email protected]> > --- > CC: Jan Beulich <[email protected]> > CC: Roger Pau Monné <[email protected]> > CC: Wei Liu <[email protected]> > CC: Stefano Stabellini <[email protected]> > CC: Julien Grall <[email protected]> > CC: Volodymyr Babchuk <[email protected]> > CC: Bertrand Marquis <[email protected]> > CC: Michal Orzel <[email protected]> > CC: Bob Eshleman <[email protected]> > CC: Alistair Francis <[email protected]> > CC: Connor Davis <[email protected]> > CC: Shawn Anastasio <[email protected]> > > Why does PPC have a local copy of ilog2() here? Especially as it's not used, > and there's a perfectly good one in <xen/bitops.h>
I believe this was a carryover from before we had asm/bitops.h implemented on PPC. Now that we have bitops implemented (and we don't define any offsets that use log2 anymore anyways), this is fine to remove. Will submit a patch to do so. As for the actual contents of this patch, Acked-by: Shawn Anastasio <[email protected]> Thanks, Shawn
