On 26.01.2024 16:42, Oleksii Kurochko wrote:
> Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com>
I'm not an Arm maintainer, but if I was I wouldn't let you get away with
an empty description here. Specifically at least ...
> --- a/xen/arch/arm/device.c
> +++ b/xen/arch/arm/device.c
> @@ -16,7 +16,10 @@
> #include <xen/lib.h>
>
> extern const struct device_desc _sdevice[], _edevice[];
> +
> +#ifdef CONFIG_ACPI
> extern const struct acpi_device_desc _asdevice[], _aedevice[];
> +#endif
>
> int __init device_init(struct dt_device_node *dev, enum device_class class,
> const void *data)
> @@ -45,6 +48,7 @@ int __init device_init(struct dt_device_node *dev, enum
> device_class class,
> return -EBADF;
> }
>
> +#ifdef CONFIG_ACPI
> int __init acpi_device_init(enum device_class class, const void *data, int
> class_type)
> {
> const struct acpi_device_desc *desc;
> @@ -61,6 +65,7 @@ int __init acpi_device_init(enum device_class class, const
> void *data, int class
>
> return -EBADF;
> }
> +#endif
... this new #ifdef-ary would want justifying, imo.
Jan
