> On 31 Jan 2024, at 10:55, Andrew Cooper <andrew.coop...@citrix.com> wrote:
>
> On 31/01/2024 10:44 am, Christian Lindig wrote:
>>> On 31 Jan 2024, at 10:42, Edwin Török <edwin.to...@cloud.com> wrote:
>>>
>>> Fix building oxenstored with OCaml 5.x.
>>> OCaml 5.x has removed some functions that have been deprecated for many
>>> years,
>>> in order to support OCaml 5.x we need to drop support for OCaml 4.02.
>>>
>>> Tested in gitlab CI (together with my other series):
>>> https://gitlab.com/xen-project/people/edwintorok/xen/-/pipelines/1158302827
>>>
>>> Edwin Török (2):
>>> oxenstored: fix build on OCaml 5.x
>>> tools/ocaml: bump minimum version to OCaml 4.05
>>>
>>> tools/configure | 2 +-
>>> tools/configure.ac | 2 +-
>>> tools/ocaml/xenstored/disk.ml | 2 +-
>>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> --
>>> 2.43.0
>>>
>> Acked-by: Christian Lindig <christian.lin...@cloud.com>
>
> It occurs to me that this is the kind of thing which should get a
> CHANGELOG.md entry these days. Something like:
>
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index 1f55c9c72d10..fd7c8f5c6b82 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -9,6 +9,7 @@ The format is based on [Keep a
> Changelog](https://keepachangelog.com/en/1.0.0/)
> ### Changed
> - Changed flexible array definitions in public I/O interface headers
> to not
> use "1" as the number of array elements.
> + - The minimum supported Ocaml toolchain version is now 4.05
> - On x86:
> - HVM PIRQs are disabled by default.
> - Reduce IOMMU setup time for hardware domain.
Sounds good.
Should this be mentioned in
https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_Patch_Series?
Best regards,
—Edwin
>
>
> ought to do.
>
> Have we checked to see whether this drops Ocaml from any of the build
> containers ?
I can look into this later, haven’t tried rebuilding the containers (the gitlab
CI passed though)
Best regards,
—Edwin
>
> ~Andrew
