On 29.01.2024 18:18, Carlo Nonato wrote: > PGC_static and PGC_extra are flags that needs to be preserved when assigning > a page. Define a new macro that groups those flags and use it instead of > or'ing every time.
While here you say where the "preserving" applies, ... > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -157,6 +157,8 @@ > #define PGC_static 0 > #endif > > +#define PGC_preserved (PGC_extra | PGC_static) ... nothing is said here. From the earlier version I also seem to recall that the constant was then used outside of assign_pages(). That would then mean amending whatever comment would be added here. Jan
