On 06.02.2024 10:28, Roger Pau Monné wrote:
> On Mon, Feb 05, 2024 at 02:37:44PM +0100, Jan Beulich wrote:
>> This is a prereq to enabling e.g. the MSRLIST feature.
>>
>> Note that the PROCBASED_CTLS3 MSR is different from other VMX feature
>> reporting MSRs, in that all 64 bits report allowed 1-settings.
>>
>> vVMX code is left alone, though, for the time being.
>>
>> Signed-off-by: Jan Beulich <[email protected]>
>
> Reviewed-by: Roger Pau Monné <[email protected]>
Thanks.
>> @@ -2068,10 +2111,12 @@ void vmcs_dump_vcpu(struct vcpu *v)
>> vmr(HOST_PERF_GLOBAL_CTRL));
>>
>> printk("*** Control State ***\n");
>> - printk("PinBased=%08x CPUBased=%08x SecondaryExec=%08x\n",
>> + printk("PinBased=%08x CPUBased=%08x\n",
>> vmr32(PIN_BASED_VM_EXEC_CONTROL),
>> - vmr32(CPU_BASED_VM_EXEC_CONTROL),
>> - vmr32(SECONDARY_VM_EXEC_CONTROL));
>> + vmr32(CPU_BASED_VM_EXEC_CONTROL));
>> + printk("SecondaryExec=%08x TertiaryExec=%016lx\n",
>
> I thought you wanted to split the print into two 32bit halves here?
Indeed I wanted to, but when about to do so I noticed several other
uses of %016lx in the same function. I value consistency higher here;
if we want to introduce such splitting, I think we want to do it
uniformly. And then we may even want to think about possible ways of
indicating the desire for such splitting right in the format string.
Jan
