On 14.02.2024 09:45, Roger Pau Monné wrote: > On Wed, Feb 14, 2024 at 08:45:28AM +0100, Jan Beulich wrote: >> On 13.02.2024 23:37, Andrew Cooper wrote: >>> It's very likely something in this series, but the link to Intel might >>> just be chance of which hardware got selected, and I've got no clue why >>> there's a reset with no further logging out of Xen... >> >> I second this - even after looking closely at the patches again, I can't >> make a connection between them and the observed behavior. Didn't yet look >> at what, if anything, osstest may have to say. Do I understand correctly >> that the cited log messages are the last sign of life prior to the >> systems rebooting? > > I've found it: > > for ( addr = start; mfn_x(addr) <= mfn_x(end); mfn_add(addr, 1) ) > > Should be: > > for ( addr = start; mfn_x(addr) <= mfn_x(end); addr = mfn_add(addr, 1) ) > > mfn_add() doesn't modify the parameter. Will see about making those > helpers __must_check in order to avoid this happening in the future.
Hmm, yes, it's not the first time this has happened. But even seeing the flaw I still can't explain the observed behavior: The system ought to hang then, not instantly reboot? Jan
