On 14.02.2024 13:16, Oleksii wrote: > On Mon, 2024-02-12 at 16:20 +0100, Jan Beulich wrote: >> On 05.02.2024 16:32, Oleksii Kurochko wrote: >>> Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com> >> >> Acked-by: Jan Beulich <jbeul...@suse.com> >> again with a nit, though: >> >>> --- /dev/null >>> +++ b/xen/arch/riscv/include/asm/event.h >>> @@ -0,0 +1,40 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>> +#ifndef __ASM_RISCV_EVENT_H__ >>> +#define __ASM_RISCV_EVENT_H__ >>> + >>> +#include <xen/lib.h> >>> + >>> +void vcpu_mark_events_pending(struct vcpu *v); >>> + >>> +static inline int vcpu_event_delivery_is_enabled(struct vcpu *v) >>> +{ >>> + BUG_ON("unimplemented"); >>> + return 0; >>> +} >>> + >>> +static inline int local_events_need_delivery(void) >>> +{ >>> + BUG_ON("unimplemented"); >>> + return 0; >>> +} >>> + >>> +static inline void local_event_delivery_enable(void) >>> +{ >>> + BUG_ON("unimplemented"); >>> +} >>> + >>> +/* No arch specific virq definition now. Default to global. */ >>> +static inline bool arch_virq_is_global(unsigned int virq) >>> +{ >>> + return true; >>> +} >>> + >>> +#endif >> >> This want to gain the usual comment. > Do you mean that commit messag should be updated?
No, I indeed mean "comment". Just go look what I committed yesterday. Jan