On 15.02.2024 11:32, Anthony PERARD wrote:
> On Thu, Feb 15, 2024 at 10:30:02AM +0100, Roger Pau Monne wrote:
>> When doing a rebuild with an xen/include/config/auto.conf already present in
>> the tree, failures from Kconfig are ignored since the target is present:
>>
>> gmake -C xen install
>> gmake[1]: Entering directory '/root/src/xen/xen'
>> tools/kconfig/conf --syncconfig Kconfig
>> common/Kconfig:2: syntax error
>> common/Kconfig:1: invalid statement
>> gmake[2]: *** [tools/kconfig/Makefile:73: syncconfig] Error 1
>> UPD include/xen/compile.h
>> Xen 4.19-unstable
>> gmake[3]: Nothing to be done for 'all'.
>> gmake[2]: 'arch/x86/include/asm/asm-offsets.h' is up to date.
>>
>> Ultimately leading to a successful build despite the Kconfig error.
>>
>> Fix this by first removing xen/include/config/auto.conf before attempting to
>> regenerate, and then also make xen/include/config/auto.conf a hard dependency
>> of the build process (ie: drop the leading '-') and reordering so the .cmd
>> target is executed before including the configuration file.
>
> Could you try to revert commit 8d4c17a90b0a ("xen/build: silence make
> warnings about missing auto.conf*") instead? With a much shorter message
> like "Don't ignore Kconfig error anymore".
But that'll introduce the problem that was addressed there, won't it?
Jan
