[AMD Official Use Only - General] Hi Michal,
> -----Original Message----- > Subject: Re: [PATCH] xen/arm: Set correct per-cpu cpu_core_mask > > Hi Henry, > > On 26/02/2024 04:01, Henry Wang wrote: > > Signed-off-by: Henry Wang <[email protected]> > NIT: You first sent this patch as part of NUMA series: > https://lore.kernel.org/xen-devel/20231120025431.14845-16- > [email protected]/ > Shouldn't you retain the Arm's authorship? Ah good point, in fact I don't really know, since I basically rewrote the patch I thought it is not really needed. I will add it back in v2 since you mentioned this. > > --- > > xen/arch/arm/smpboot.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > + /* PE not implemented using a multithreading type approach. */ > > + if ( system_cpuinfo.mpidr.mt == 0 ) > Do we need this check? It mt was true, cpu_sibling_mask would be incorrect > anyway (it would still be 1). I added this check for playing safe, because I only want to do the correct thing in this patch and avoid make things worse for MT case. With this patch, non-MT case can be improved and the MT case is remain unchanged. But I agree with you, and I would be more than happy if I can run a MT setup and finish the "else" part with this patch or follow-ups. Do you know maybe qemu can allow me to emulate a MT setup so that I can fix it properly in v2? Thanks! Kind regards, Henry > > ~Michal
