On 26.02.2024 15:49, Anthony PERARD wrote:
> On Mon, Feb 26, 2024 at 10:23:37AM +0100, Jan Beulich wrote:
>> On 20.02.2024 15:07, Anthony PERARD wrote:
>>> --- a/automation/scripts/build-test.sh
>>> +++ b/automation/scripts/build-test.sh
>>> @@ -9,6 +9,37 @@
>>> # Set NON_SYMBOLIC_REF=1 if you want to use this script in detached HEAD
>>> state.
>>> # This is currently used by automated test system.
>>>
>>> +# Colors with ANSI escape sequences
>>> +txt_info='[32m'
>>> +txt_err='[31m'
>>> +txt_clr='[0m'
>>> +
>>> +# $GITLAB_CI should be "true" or "false".
>>> +if [ "$GITLAB_CI" != true ]; then
>>> + GITLAB_CI=false
>>> +fi
>>> +
>>> +gitlab_log_section() {
>>> + if $GITLAB_CI; then
>>> + echo -n "[0Ksection_$1:$(date +%s):$2
>>> [0K"
>>
>> ... there was either corruption on transmit here, or there's an embedded
>> newline that I don't know how to deal with.
>
> No corruption here, there is a \r in this string. There's also \e a few
> times. Most tools can deal with these characters just fine, so I didn't
> even think there could be an issue.
Okay, in an entirely different 2nd attempt I got it committed fine (I
hope). It's probably too old fashioned of me / my scripts that I
demand for every patch to pass a "patch --dry-run" first.
Jan
> If that byte is really an issue, I could rewrite the patch to use
> printf, and I think it would read as:
>
> printf "\e[0Ksection_$1:$(date +%s):$2\r\e[0K"
>
> Thanks,
>
