On 27.02.2024 12:20, Roger Pau Monné wrote: > On Mon, Feb 26, 2024 at 01:54:54PM +0100, Jan Beulich wrote: >> On 26.02.2024 12:07, Roger Pau Monne wrote: >>> Now that the thunk built-in enable is printed as part of the "Compiled-in >>> support:" line, avoid printing anything in "Xen settings:" if the thunk is >>> disabled at build time. >> >> Why "Now that ..."? It's other logging the earlier patch adds there. > > 'Now that ...' would refer to patch 1/4.
But that's why I'm asking: Patch 1 does not add any printing for thunk usage; it extends that and shadow-paging's printing by the three hardening ones. But anyway ... >>> Note the BTI-Thunk option printing is also adjusted to print a colon in the >>> same way the other options on the line do. >>> >>> Requested-by: Jan Beulich <[email protected]> >>> Signed-off-by: Roger Pau Monné <[email protected]> >> >> With either a clarification of what's meant or e.g. s/Now that/Since/ >> Reviewed-by: Jan Beulich <[email protected]> > > 'Since' is likely more appropriate. ... I'll switch to this then. Jan
