Re: [PATCH v4 10/12] xen/spinlock: split recursive spinlocks from normal ones

[Juergen Gross]

On 29.02.24 16:32, Jan Beulich wrote:

On 12.12.2023 10:47, Juergen Gross wrote:

+#define nrspin_lock_irqsave(l, f)                               \
+    ({                                                          \
+        BUILD_BUG_ON(sizeof(f) != sizeof(unsigned long));       \
+        ((f) = __nrspin_lock_irqsave(l));                       \

I don't think the outer pair of parentheses is needed here.

Turns out it is needed. Otherwise something like:


if ( a )
    nrspin_lock_irqsave(l, f);
else
    ...

will fail with "else without a previous if".


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

OpenPGP_signature.asc
Description: OpenPGP digital signature