On 11.03.2024 13:07, Simone Ballarin wrote: > On 11/03/24 11:10, Jan Beulich wrote: >> On 11.03.2024 09:59, Simone Ballarin wrote: >>> --- a/xen/arch/arm/efi/efi-boot.h >>> +++ b/xen/arch/arm/efi/efi-boot.h >>> @@ -3,6 +3,10 @@ >>> * is intended to be included by common/efi/boot.c _only_, and >>> * therefore can define arch specific global variables. >>> */ >>> + >>> +#ifndef XEN_ARCH_ARM_EFI_EFI_BOOT_H >>> +#define XEN_ARCH_ARM_EFI_EFI_BOOT_H >> >> Related to my question raised against the cover letter, what does the >> XEN_ prefix gain us here? All building of the hypervisor binaries >> happens inside the xen/ subtree. > > what do you thing about adding this rule: > arch/<arch>/<subdir>/<filename> -> <ARCH>_<subdir>_<filename>_H > ?
Yet better - even the ARCH_ is gone then. Of course we want to then be reasonably sure no arch appears with a name matching some of the other top-level (under xen/) subdirs. Jan
