On 13/03/2024 5:27 pm, Andrew Cooper wrote: > diff --git a/xen/common/bitops.c b/xen/common/bitops.c > index 484df68768ad..eceffe5029d6 100644 > --- a/xen/common/bitops.c > +++ b/xen/common/bitops.c > @@ -40,6 +40,13 @@ static void test_ffs(void) > CHECK(ffs, 0, 0); > CHECK(ffs, 1, 1); > CHECK(ffs, 0x80000000U, 32); > + > + /* unsigned int ffsl(unsigned long) */ > + CHECK(ffsl, 0, 0); > + CHECK(ffsl, 1, 1); > + CHECK(ffsl, 1UL << (BITS_PER_LONG - 1), BITS_PER_LONG); > + if ( BITS_PER_LONG > 32 ) > + CHECK(ffsl, 1UL << 32, 33); > }
This if() needs to be an #if to compile on arm32. Otherwise, I've managed to make the series fully bisectable on all architectures. ~Andrew
