On 19/03/2024 1:11 pm, Jan Beulich wrote: > On 19.03.2024 08:33, Jan Beulich wrote: >> On 18.03.2024 19:13, Andrew Cooper wrote: >>> I'm not sure about FSRSC as a name, but it definitely beats AMD's longhand >>> name of FAST_REP_SCASB. >> With FSRS already used, I guess that's the closest we can get to keep >> names for similar features similar. >> >>> --- a/tools/misc/xen-cpuid.c >>> +++ b/tools/misc/xen-cpuid.c >>> @@ -91,6 +91,7 @@ static const char *const str_e1c[32] = >>> [24] = "perfctr-nb", /* [25] */ >>> [26] = "dbx", [27] = "perftsc", >>> [28] = "pcx-l2i", [29] = "monitorx", >>> + [30] = "dbext2", >>> }; >> AMD calls this AddrMaskExt (PM) or AdMskExtn (PPR). I can see where your >> different name choice is coming from, yet I still wonder whether we should >> try to stay closer where possible. > Having located the corresponding doc, > Reviewed-by: Jan Beulich <jbeul...@suse.com> > with a slight preference to adjusted names for this one feature.
Neither are great. How about "addr-msk-ext" ? ~Andrew
