On 26.03.2024 14:24, Jason Andryuk wrote: > On 2024-03-26 03:50, Jan Beulich wrote: >> On 25.03.2024 21:45, Jason Andryuk wrote: >>> + * - a minimum address for the start of the image (default 0) >>> + * - a required start alignment (default 0x200000) >>> + * >>> + * This note is only valid for x86 binaries. >> >> Maybe s/valid/recognized/ (or honored or some such)? > > Would a comment at the top of the file saying Notes are only used with > x86 be better instead of this one-off comment? Roger already said that, > and elf_xen_note_check() has a successful early exit with "ELF: Not > bothering with notes on ARM\n"
If truly none of the notes are of interest for Arm, then yes, such a more general comment would likely make sense. Jan