Hi Jan, On 3/25/24 10:19 AM, Jan Beulich wrote: > On 14.03.2024 23:15, Shawn Anastasio wrote: >> Introduce a generic acpi.h header that provides the required definitions >> to allow files including xen/acpi.h to be compiled. The definitions were >> largely derived from the !CONFIG_ACPI parts of ARM's acpi.h. > > As said a couple of times in discussion with Oleksii on his work towards > populating asm-generic/, I view a use like this as an abuse of this > asm-generic machinery. Instead imo said !CONFIG_ACPI parts from Arm's header > want moving to xen/acpi.h, eliminating the need for asm/acpi.h for > architectures / configurations not supporting ACPI. Much like was done > with e.g. xen/numa.h. >
In this case I'm not sure I fully agree, since the definitions here aren't really stubs but rather more-or-less fully complete architecture-independent implementations of these symbols for the !CONFIG_ACPI case. That said, after you mentioned the other route of modifying xen/acpi.h, I found that going that route required fewer changes, so I'll proceed with that approach. > Jan Thanks, Shawn
