Hi Michal, > On 17 Apr 2024, at 13:14, Michal Orzel <[email protected]> wrote: > > Commit afab29d0882f ("public: s/int/int32_t") replaced int with int32_t > in XEN_GUEST_HANDLE() in memory.h but there is no guest handle defined > for it. This results in a build failure. Example on Arm: > > ./include/public/arch-arm.h:205:41: error: unknown type name > ‘__guest_handle_64_int32_t’ > 205 | #define __XEN_GUEST_HANDLE(name) __guest_handle_64_ ## name > | ^~~~~~~~~~~~~~~~~~ > ./include/public/arch-arm.h:206:41: note: in expansion of macro > ‘__XEN_GUEST_HANDLE’ > 206 | #define XEN_GUEST_HANDLE(name) __XEN_GUEST_HANDLE(name) > | ^~~~~~~~~~~~~~~~~~ > ./include/public/memory.h:277:5: note: in expansion of macro > ‘XEN_GUEST_HANDLE’ > 277 | XEN_GUEST_HANDLE(int32_t) errs; > > Fix it. Also, drop guest handle definition for int given no further use. > > Fixes: afab29d0882f ("public: s/int/int32_t") > Signed-off-by: Michal Orzel <[email protected]> > ---
I’ve build it for arm64, arm32 and x86 Reviewed-by: Luca Fancellu <[email protected]> Tested-by: Luca Fancellu <[email protected]>
