18.04.24 14:36, Jan Beulich:
On 16.04.2024 08:29, Sergiy Kibrik wrote:
Move altp2m code from generic p2m.c file to altp2m.c, so that VMX-specific
code is kept separately and can possibly be disabled in the build.
The code movement is desirable, but the reasoning isn't quite right (see
replies on other sub-threads).
understood
--- a/xen/arch/x86/mm/altp2m.c
+++ b/xen/arch/x86/mm/altp2m.c
@@ -9,6 +9,8 @@
#include <asm/altp2m.h>
#include "mm-locks.h"
#include "p2m.h"
+#include <public/hvm/hvm_op.h>
+#include <xen/event.h>
Please add above the private header #include-s.
ok
[...]
+ return rc;
+}
+
+
No double blank lines please, anywhere.
yes, go it
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -500,9 +500,8 @@ int p2m_alloc_table(struct p2m_domain *p2m)
return 0;
}
-static int __must_check
-p2m_remove_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
- unsigned int page_order)
+int __must_check p2m_remove_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
+ unsigned int page_order)
{
And no unrelated re-formatting please (i.e. you really only need to
touch a single line here).
will fix that
-Sergiy
