On 19.04.2024 12:16, Andrew Cooper wrote: > On 19/04/2024 11:12 am, Jan Beulich wrote: >> On 19.04.2024 12:08, Andrew Cooper wrote: >>> On 19/04/2024 11:02 am, Roger Pau Monne wrote: >>>> Start by declaring the beginning and end of the init section. >>>> >>>> No functional change intended. >>>> >>>> Requested-by: Andrew Cooper <andrew.coop...@citrix.com> >>>> Signed-off-by: Roger Pau Monné <roger....@citrix.com> >>> TYVM for doing this. There's a lot of cleanup which can follow on for it. >>> >>> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> >>> >>> although if anyone has a better name than sections.h then speak now. >> For what is put there now, and for any other section bounds markers the >> name is fine with me. I'm not presently convinced though we want to put >> __read_mostly and friends there. > > Well that's exactly what I intend to clean up into it, because it's far > better in sections.h than (duplicated per arch) cache.h
The duplication per arch has had a patch pending for a long time, which you've been blocking. What you're suggesting is not only a very different sections-related use of the header (which is probably okay), but also requires touching a fair part of the code base (each and every .c file using __read_mostly). That's what I'd like to avoid. Yet what I could live with if it's not me needing to perform this tedious work (hence why I didn't want to adjust my patch along these lines). > (Also I intend to strip down kernel.h for the other major sections too.) I certainly have no issue with this; I was in fact already expecting that to happen as a follow-on step. Jan
