On 13/06/18 15:31, Jan Beulich wrote:
> J├╝rgen, Boris,
> 
> aren't headers in uapi/ directories supposed to be self contained?

Hmm, there are many uapi headers including stuff from outside uapi.
I guess it is okay to include headers which are accessible in the
kernel _and_ under /usr/include or to put such includes under
#ifdef __KERNEL__

> The addition done by David in fbc872c38c clearly isn't, as there's
> no domid_t anywhere in other uapi/ headers afaict. No idea how
> to reasonably adjust this; I'd in particular dislike using __u16 there,
> but perhaps that's the only option we have.

include/uapi/xen/privcmd.h is especially evil: it is including the
kernel-only xen/interface/xen.h

Xen tools avoid the resulting problems by using a private copy of that
file without the offending #include. OMG!


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to