On Tue, Apr 23, 2024 at 03:33:36PM +0200, Jan Beulich wrote: > On 23.04.2024 15:12, Roger Pau Monne wrote: > > It's incorrect to restrict strncmp to the length of the command line input > > parameter, as then a user passing a rune like: > > > > % xen-livepatch up foo.livepatch > > > > Would match against the "upload" command, because the string comparison has > > been truncated to the length of the input argument. Instead the truncation > > should be done based on the length of the command name stored in the > > internal > > array of actions. > > But then "xen-livepatch upload-or-not foo.livepatch" would still wrongly > match. Why strncmp() at all, rather than strcmp()?
Bah, indeed, how dumb of me. Will switch to strcmp in the next version. Thanks, Roger.-
