On 24.04.2024 05:34, Henry Wang wrote: > From: Vikram Garhwal <[email protected]> > > Introduce a shell script that runs in the background and calls > get_overlay to retrive overlays and add them (or remove them) to Linux > device tree (running as a domU). > > Signed-off-by: Vikram Garhwal <[email protected]> > Signed-off-by: Stefano Stabellini <[email protected]> > Signed-off-by: Henry Wang <[email protected]> > --- > tools/helpers/Makefile | 2 +- > tools/helpers/get_overlay.sh | 81 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 82 insertions(+), 1 deletion(-) > create mode 100755 tools/helpers/get_overlay.sh
Besides the same naming issue as in the earlier patch, the script also looks very Linux-ish. Yet ... > --- a/tools/helpers/Makefile > +++ b/tools/helpers/Makefile > @@ -58,7 +58,6 @@ init-dom0less: $(INIT_DOM0LESS_OBJS) > get_overlay: $(SHARE_OVERLAY_OBJS) > $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenvchan) $(LDLIBS_libxenstore) > $(LDLIBS_libxenctrl) $(LDLIBS_libxengnttab) $(APPEND_LDFLAGS) > > - > .PHONY: install > install: all > $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN) > @@ -67,6 +66,7 @@ install: all > .PHONY: uninstall > uninstall: > for i in $(TARGETS); do rm -f $(DESTDIR)$(LIBEXEC_BIN)/$$i; done > + $(RM) $(DESTDIR)$(LIBEXEC_BIN)/get_overlay.sh > > .PHONY: clean > clean: ... you touching only the uninstall target, it's not even clear to me how (and under what conditions) the script is going to make it into $(DESTDIR)$(LIBEXEC_BIN)/. Did you mean to add to $(TARGETS), perhaps, alongside the earlier added get-overlay binary? Jan
