On 4/24/24 12:34, Daniel P. Smith wrote:
An issue ran into by hyperlaunch was the need to use the gzip decompressor
multiple times. The current implementation fails when reused due to tainting of
decompressor state from a previous usage. This series seeks to colocate the
gzip unit files under a single directory similar to the other decompression
algorithms. To enable the refactoring of the state tracking, the code is then
cleaned up in line with Xen coding style.
Forgot to add this comment to the cover letter.
Concern was raised about taking updates from original source to the
code. In this case the original source is from the Linux kernel, which
can be found in lib/inflate.c, and added to Xen in 2009. The last time
there was a logic change to that code in the Linux kernel was in 2008,
before it was added to Xen. Since then, it has only been updated for
changes made to included headers. If fact, as far as I can see, while
the file is still in place, nothing uses it. For zlib decompression,
three is a new lib/zlib_deflate code base that is used. The scope of
this work is not to completely fix/replace zlib decompression for Xen,
but to stabilize it to allow hyperlaunch to decompress more than one
zlib compressed kernel.
V/r,
Daniel P. Smith
