On 2023-12-18 09:48, Jan Beulich wrote:
... in order to also deny Dom0 access through the alias ports. Without
this it is only giving the impression of denying access to both PICs.
Unlike for CMOS/RTC, do detection very early, to avoid disturbing normal
operation later on.

Like for CMOS/RTC a fundamental assumption of the probing is that reads
from the probed alias port won't have side effects in case it does not
alias the respective PIC's one.

Signed-off-by: Jan Beulich <jbeul...@suse.com>

Code-wise
Reviewed-by: Jason Andryuk <jason.andr...@amd.com>

I appreciate what Jan is trying to achieve. I also share Roger's concern about reading IO ports since we don't know what is there.

I also don't have a good alternative to suggest...

Regards,
Jason

Reply via email to