Hi Michal, >> >> - /* >> - * "role" property is optional and if it is defined explicitly, >> - * then the owner domain is not the default "dom_io" domain. >> - */ >> - if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) >> - owner_dom_io = false; >> + /* "role" property is optional */ >> + dt_property_read_string(shm_node, "role", &role_str); > This now violates a MISRA rule saying that if a function returns a value, > this value needs to be checked. > I think you should check if return value is non zero and if such, assign > role_str NULL (thus removing such > assignment from a definition).
Sure, I’ll do it. > > Other than that: > Reviewed-by: Michal Orzel <michal.or...@amd.com> > > ~Michal Cheers, Luca
