On 01.06.2024 12:16, Nicola Vetrini wrote: > MISRA C Rule 20.12 states: "A macro parameter used as an operand to > the # or ## operators, which is itself subject to further macro replacement, > shall only be used as an operand to these operators". > > In this case, builds where CONFIG_DEBUG_LOCK_PROFILE=y the domain_lock > macro is used both as a regular macro argument and as an operand for > stringification in the expansion of macro spin_lock_init_prof.
The shouldn't the marker be on the definition of spin_lock_init_prof(), rather than ... > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -632,6 +632,7 @@ struct domain *domain_create(domid_t domid, > > atomic_set(&d->refcnt, 1); > RCU_READ_LOCK_INIT(&d->rcu_lock); > + /* SAF-6-safe Rule 20.12 expansion of macro domain_lock in debug builds > */ > rspin_lock_init_prof(d, domain_lock); > rspin_lock_init_prof(d, page_alloc_lock); > spin_lock_init(&d->hypercall_deadlock_mutex); ... actually just one of the two uses here (and presumably several more elsewhere)? Jan
