On 27.05.2024 14:54, [email protected] wrote: > --- a/tools/flask/utils/loadpolicy.c > +++ b/tools/flask/utils/loadpolicy.c > @@ -58,6 +58,11 @@ int main (int argCnt, const char *args[]) > } > > polMemCp = malloc(info.st_size); > + if (!polMemCp) { > + fprintf(stderr, "Error occurred allocating %ld bytes\n", > info.st_size); > + ret = -ENOMEM;
I don't think -ENOMEM is valid to use here. See neighboring code. Nevertheless it is correct that a check should be here. As to %ld - is that portably usable with an off_t value? In any event, Daniel, really your turn to review / ack. I'm looking at this merely because I found this and another bugfix still sit in waiting-for-ack state. Jan
