On 19.06.2024 19:09, Alessandro Zucchelli wrote: > From: Nicola Vetrini <[email protected]> > > The rule disallows the usage of an identifier reserved by the C standard. > All identfiers starting with '__' are reserved for any use, so the label > can be renamed in order to avoid the violation. > > No functional change. > > Signed-off-by: Nicola Vetrini <[email protected]>
While the code change is certainly okay (with a cosmetic remark below), you sending a change Nicola made requires, aiui, you own S-o-b as well. > @@ -941,7 +941,7 @@ void __init init_apic_mappings(void) > apic_printk(APIC_VERBOSE, "mapped APIC to %08Lx (%08lx)\n", APIC_BASE, > apic_phys); > > -__next: > +next: While touching this (or any) label, can you please also make sure that from now on it respects this section of ./CODING_STYLE (part of the section "Indentation")? "Due to the behavior of GNU diffutils "diff -p", labels should be indented by at least one blank. Non-case labels inside switch() bodies are preferred to be indented the same as the block's case labels." Jan
