libxl__domain_build_info_setdefault sets libxl_domain_build_info->device_model_version unconditionally to LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN. This breaks domUs that do not have a qemu attached to it, like PV without vfb= and without qdisk. While that bug does not trigger today, it will once https://lists.xenproject.org/archives/html/xen-devel/2018-05/msg01077.html is merged.
Why would it be a good idea to set ->device_model_version to a bogus value, instead of introducing a concept of device_model_version=NONE? Olaf
pgp5aeaQOhmcE.pgp
Description: Digitale Signatur von OpenPGP
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
