On 27.06.2024 02:52, Stefano Stabellini wrote: > On Wed, 26 Jun 2024, Federico Serafini wrote: >> Add break or pseudo keyword fallthrough to address violations of >> MISRA C Rule 16.3: "An unconditional `break' statement shall terminate >> every switch-clause". >> >> No functional change. >> >> Signed-off-by: Federico Serafini <federico.seraf...@bugseng.com> >> --- >> Changes in v3: >> - use break instead of fallthrough. >> --- >> xen/arch/x86/traps.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c >> index 9906e874d5..d62598a4c2 100644 >> --- a/xen/arch/x86/traps.c >> +++ b/xen/arch/x86/traps.c >> @@ -1186,6 +1186,7 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, >> uint32_t leaf, >> >> default: >> ASSERT_UNREACHABLE(); >> + break; > > FYI the ASSERT_UNREACHABLE is still being discussed
Could you clarify what this means for this patch and you R-b? Is it somehow conditional upon the outcome of that discussion, and hence you'd rather not see this patch go in yet? > Other than that: > > Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Acked-by: Jan Beulich <jbeul...@suse.com> Jan
