On 26.06.2024 11:28, Federico Serafini wrote: > --- a/xen/arch/x86/hvm/vpt.c > +++ b/xen/arch/x86/hvm/vpt.c > @@ -118,9 +118,11 @@ static int pt_irq_masked(struct periodic_time *pt) > return 0; > > gsi = hvm_isa_irq_to_gsi(pt->irq); > + > + /* Fallthrough to check if the interrupt is masked on the IO APIC. */ > + fallthrough; > } > > - /* Fallthrough to check if the interrupt is masked on the IO APIC. */ > case PTSRC_ioapic: > { > int mask = vioapic_get_mask(v->domain, gsi);
See question on patch 7. Plus the blank line may want purging here along with the comment, to be consistent with what you're doing elsewhere. Jan