10.07.24 13:19, Jan Beulich:
looking through these changes once again I wonder why can't we just move stub to the header like this:in xen/include/xen/ioreq.h: #ifdef arch_vcpu_ioreq_completion #ifdef CONFIG_VMX bool arch_vcpu_ioreq_completion(enum vio_completion completion); #else static inline bool arch_vcpu_ioreq_completion(enum vio_completion completion) { ASSERT_UNREACHABLE(); return true; } #endif and avoid additional pre-processor variables & conditionals, because it looks like we do need some kind of stub that does ASSERT_UNREACHABLE() anyway.That's possible to do, yes, but not as long as you key it off of CONFIG_VMX. This arch-specific setting would better not be used in a common code header. You could introduce a helper CONFIG_* which VMX selects, at which point doing what you suggest is an option.
ok, I'll try this option in next series, lets see how it will look
However, in what you have above I can't figure why "#ifdef arch_vcpu_ioreq_completion" is still there.
disregard it please, a copy-paste error -Sergiy
