On 12/07/2024 1:33 pm, Anthony PERARD wrote: > On Fri, Jul 12, 2024 at 12:14:26PM +0100, Andrew Cooper wrote: >> while removed are: >> >> bc # ? > I don't know why, but this one is also installed by osstest. The commit > adding it doesn't say why it was needed. > > Also, looks like many QEMU containers are installing `bc`, but I can't > find a single use. Maybe historic.
Part of the reason why our containers are so massive is because dependencies only ever accumulate... But yes - this one is especially odd. >> nasm # ? > 'nasm' is used to build OVMF. > > > If we don't want to build OVMF in our GitLab CI, which I don't think > would be useful to do anyway (no dependency on xen.git) Oh, interesting. I'd assumed (by virtue of the jobs succeeding) that we were building OVMF by default, but we're clearly not. ./configure says: --enable-ovmf Enable OVMF (default is DISABLED) so it's really just a simple opt-in, which our build script does not. In the longer term, we will want OVMF in Gitlab CI, but we'd want to pull it in as a separate artefact and use --with-system-ovmf=/path/to/artefact So I agree we don't need to build OVMF inside this container. > , then: > > Reviewed-by: Anthony PERARD <[email protected]> Thanks. ~Andrew
