> -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 22 June 2018 11:53 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com>; xen-devel <xen- > de...@lists.xenproject.org>; Juergen Gross <jgr...@suse.com> > Subject: Ping: [PATCH 2/2] x86/HVM: attempts to emulate FPU insns need to > set fpu_initialised > > >>> On 15.06.18 at 10:58, <jbeul...@suse.com> wrote: > > My original way of thinking here was that this would be set anyway at > > the point state gets reloaded after the adjustments hvmemul_put_fpu() > > does, but the flag should already be set before that - after all the > > guest may never again touch the FPU before e.g. getting migrated/saved. > > > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > > > > --- a/xen/arch/x86/hvm/emulate.c > > +++ b/xen/arch/x86/hvm/emulate.c > > @@ -2053,6 +2053,7 @@ static int hvmemul_get_fpu( > > * masking of all exceptions by FNSTENV.) > > */ > > save_fpu_enable(); > > + curr->fpu_initialised = true; > > curr->fpu_dirtied = true; > > if ( (fpu_ctxt->fcw & 0x3f) != 0x3f ) > > { >
Apologies for the delay... Acked-by: Paul Durrant <paul.durr...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
