On 2024-07-24 08:41, Jan Beulich wrote:
On 23.07.2024 17:04, Anthony PERARD wrote:
On Mon, Jul 15, 2024 at 07:46:31PM -0400, Jason Andryuk wrote:
"$dev" needs to be set correctly for backendtype=phy as well as
backendtype=tap. Move the setting into the conditional, so it can be
handled properly for each.
(dev could be captured during tap-ctl allocate for blktap module, but it
would not be set properly for the find_device case. The backendtype=tap
case would need to be handled regardless.)
Fixes: 6fcdc84927 ("hotplug: Restore block-tap phy compatibility")
Do you mean f16ac12bd418 ("hotplug: Restore block-tap phy compatibility") ?
Which, when replacing it, made noticeable that the above and ...
Fixes: 76a484193d ("hotplug: Update block-tap")
... this hash also were too short. Please make sure you use 12 digits, as
indicated by docs/process/sending-patches.pandoc.
Sorry about that. I'll make sure to use 12 in the future. Thanks for
catching and fixing up.
Regards,
Jason
