On 26/06/18 10:57, Jan Beulich wrote: > >>> + _p(regs->rip), _p(regs->rip), _p(fixup)); >>> + /* >>> + * We mustn't come here, but for release builds have the recovery >> "We shouldn't be able to reach here..." > Well, okay - I did consider this weaker wording, but had opted for the > stronger one then.
"mustn't" isn't the intended phrasing here, although I'm having a very hard time trying to describe the difference vs "shouldn't be able to" in this context. By the time people are poking around in this code, the "mustn't" has clearly been violated, whereas the "shouldn't be able to" is accepting of the fact that we have got here, and something previously has gone wrong. I realise this is probably a very unhelpful description. ~Andrew _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
