On 23/08/2024 4:35 pm, Nicola Vetrini wrote: > On 2024-08-23 01:06, Andrew Cooper wrote: >> diff --git a/xen/lib/generic-hweightl.c b/xen/lib/generic-hweightl.c >> index fa4bbec273ab..4b39dd84de5e 100644 >> --- a/xen/lib/generic-hweightl.c >> +++ b/xen/lib/generic-hweightl.c >> @@ -43,4 +43,19 @@ static void __init __constructor >> test_generic_hweightl(void) >> RUNTIME_CHECK(generic_hweightl, 1 | (1UL << (BITS_PER_LONG - >> 1)), 2); >> RUNTIME_CHECK(generic_hweightl, -1UL, BITS_PER_LONG); >> } >> + >> +#ifdef CONFIG_X86 >> +unsigned int arch_generic_hweightl(unsigned long); > > Hi Andrew, > > do you mind putting a parameter name here, as the current form > introduces a violation of MISRA Rule 8.2 [1] (even if unnecessary, > given its implementation)?
Sorry. I did run Eclair on this series during development, but this was a late change and I forgot to re-check. Fixed locally. ~Andrew
