On 23.08.2024 01:06, Andrew Cooper wrote: > ... and drop generic_hweight32(). > > As noted previously, the only two users of hweight32() and they're both > singleton callers in __init paths, so it's not interesting to have a sub-GPR > optimised generic.
I think it's clear what is meant, but the part of the sentence ahead of the comma is a little bumpy. As to not interesting: Perhaps indeed not right now, but new uses may appear and generally the overly wide operations may be (slightly) more expensive. Of course we can deal with the need when it arises, so ... > No functional change. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Acked-by: Jan Beulich <jbeul...@suse.com>
