On 03/09/2024 9:46 am, Michal Orzel wrote: > > On 02/09/2024 12:03, Andrew Cooper wrote: >> >> There are no bits set in lr_mask beyond nr_lrs, so when substituting >> bitmap_for_each() for for_each_set_bit(), we don't need to worry about the >> upper bound. >> >> However, the type of lr_mask does matter, so switch it to be uint64_t * and >> move unsigned long * override until the find_next_zero_bit() call. >> >> Move lr_val into a narrower scope and drop used_lr as it's declared by >> for_each_set_bit() itself. >> >> Drop the nr_lrs variable and use gic_get_nr_lrs() in the one location its now >> used. It hides a triple pointer defererence, and while it may not be needed > s/defererence/dereference
Fixed. > >> in the PRISTINE case, it certainly doesn't need to be live across the rest of >> the function. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper <[email protected]> > Reviewed-by: Michal Orzel <[email protected]> Thanks. ~Andrew
