On 06/09/2024 3:20 pm, Andrii Sultanov wrote: >> > diff --git > a/tools/ocaml/libs/xenstoredglue/domain_getinfo_plugin_v1/Makefile > b/tools/ocaml/libs/xenstoredglue/domain_getinfo_plugin_v1/Makefile >> > new file mode 100644 >> > index 0000000000..9c40026cab >> > --- /dev/null >> > +++ b/tools/ocaml/libs/xenstoredglue/domain_getinfo_plugin_v1/Makefile >> > @@ -0,0 +1,38 @@ >> > +OCAML_TOPLEVEL=$(CURDIR)/../../.. >> > +XEN_ROOT=$(OCAML_TOPLEVEL)/../.. >> > +include $(OCAML_TOPLEVEL)/common.make >> > + >> > +CFLAGS += -I $(OCAML_TOPLEVEL)/libs -I > $(OCAML_TOPLEVEL)/libs/xenstoredglue >> > +CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_xeninclude) $(APPEND_CFLAGS) >> > +OCAMLOPTFLAGS += -opaque >> > +OCAMLINCLUDE += -I ./ -I ../ >> >> I think we only need "-I ../" here. xen-caml-compat.h is the only local >> header used. > > With only "-I ../", the build fails: > ``` > ocamlopt -g -ccopt " " -dtypes -I ../ -w F -warn-error F -opaque > -shared -linkall -o domain_getinfo_v1.cmxs domain_getinfo_v1.cmxa > /usr/bin/ld: cannot find -ldomain_getinfo_v1_stubs: No such file or > directory > collect2: error: ld returned 1 exit status > ```
Oh ok. Better keep it then. ~Andrew
