On 08/09/2024 2:27 pm, Nicola Vetrini wrote:
> Prior to bd1664db7b7d ("xen/bitops: Introduce a multiple_bits_set() helper")
> the definition of {COMPILE,RUNTIME}_CHECK was fully compliant with respect
> to MISRA C Rule 20.7:
>
> "Expressions resulting from the expansion of macro parameters shall be
> enclosed in parentheses."
>
> However, to allow testing function-like macros, parentheses on the "fn"
> parameter were removed and thus new violations of the rule have been
> introduced. Given the usefulness of this functionality,
> it is deemed ok to deviate these two macros for this rule, because
> their scope of (direct) usage is limited to just the file where they
> are defined, and the possibility of misuses is unlikely.
>
> No functional change.
>
> Fixes: bd1664db7b7d ("xen/bitops: Introduce a multiple_bits_set() helper")
> Signed-off-by: Nicola Vetrini <nicola.vetr...@bugseng.com>Sorry for breaking this. I did check that Eclair was green with the patch in place, assuming that this rule was already clean. Acked-by: Andrew Cooper <andrew.coop...@citrix.com> I'll try to keep this in mind when extending self-tests further.
