On 18.09.2024 16:11, Stewart Hildebrand wrote: > On 8/28/24 06:36, Jan Beulich wrote: >> On 27.08.2024 05:59, Stewart Hildebrand wrote: >>> + list_for_each_entry_safe(vf_pdev, tmp, >>> &pdev->physfn.vf_list, >>> + virtfn.entry) >>> + ret = pci_remove_device(vf_pdev->sbdf.seg, >>> + vf_pdev->sbdf.bus, >>> + vf_pdev->sbdf.devfn) ?: ret; >> >> And if this fails, the VF will still remain orphaned. I think in the >> model I had suggested no such risk would exist. > > Are you referring to your suggestion "to refuse the request (in > pci_remove_device()) when the list isn't empty" ? [1] Or something else? > > [1] > https://lore.kernel.org/xen-devel/74f88a45-a632-4ca6-9cee-95f52370b...@suse.com/
It's been a while, but yes, I think that's the one. Jan
