On 9/4/24 02:26, Jan Beulich wrote:
On 30.08.2024 23:46, Daniel P. Smith wrote:
--- a/xen/arch/x86/include/asm/bootinfo.h
+++ b/xen/arch/x86/include/asm/bootinfo.h
@@ -8,11 +8,16 @@
#ifndef __XEN_X86_BOOTINFO_H__
#define __XEN_X86_BOOTINFO_H__
+#include <xen/types.h>
+
struct boot_info {
unsigned int nr_mods;
const char *boot_loader_name;
const char *cmdline;
+
+ paddr_t mmap_addr;
+ uint32_t mmap_length;
Why would this need to be a fixed-width type, unless we went in the direction
of what Alejandro mentioned in reply to patch 1? IOW at least we want to be
consistent with which kind of types are used here.
At of right now, I would prefer not to go down the path of a boot
protocol, but I am willing to have the discussion if a majority pushes
for it. Unless that happens, I will switch this to size_t.
v/r,
dps
