Re: [PATCH v4 07/44] x86/boot: move headroom to boot modules

[Daniel P. Smith]

On 9/4/24 02:45, Jan Beulich wrote:
On 30.08.2024 23:46, Daniel P. Smith wrote:
The purpose of struct boot_module is to encapsulate the state of boot modules.
Doing locates boot module state with its respective boot module, reduces

I'm struggling with the start of this sentence.

Yep, grammar check failed to catch. Will fix.

@@ -1390,7 +1390,9 @@ void asmlinkage __init noreturn __start_xen(unsigned long 
mbi_p)
          mod[boot_info->nr_mods].mod_end = __2M_rwdata_end - _stext;
      }
  
-    modules_headroom = bzimage_headroom(bootstrap_map(mod), mod->mod_end);
+    boot_info->mods[0].headroom = bzimage_headroom(
+                        bootstrap_map(boot_info->mods[0].early_mod),
+                        boot_info->mods[0].early_mod->mod_end);

Nit: This is badly indented. Either

     boot_info->mods[0].headroom = bzimage_headroom(
         bootstrap_map(boot_info->mods[0].early_mod),
         boot_info->mods[0].early_mod->mod_end);

or

     boot_info->mods[0].headroom =
         bzimage_headroom(
             bootstrap_map(boot_info->mods[0].early_mod),
             boot_info->mods[0].early_mod->mod_end);

or

     boot_info->mods[0].headroom =
         bzimage_headroom(bootstrap_map(boot_info->mods[0].early_mod),
                          boot_info->mods[0].early_mod->mod_end);

Even shortening "boot_info" will not avoid some line wrapping here, as it
looks.

I would lean towards the latter, as I find it the most clear. With the 
shortening of "boot_info" and dropping "early_" per Andy, It might bring 
it up one line. Will see when I do it.

v/r,
dps